Skip to content

Loading…

[Firefox on Android] Hostnames in the popup are out of order sometimes #1020

Closed
my-password-is-password opened this Issue · 11 comments

2 participants

@my-password-is-password

I just saw this happening and not sure exactly when it happens. So far this is what I've noticed

  • When I try "Open Link in New Tab" ( #1001 ), it happens
  • When I try "opening new tabs in Firefox from 3rd party apps" ( #1017 ), it happens
  • Going to a site by typing out the url in the location bar, it doesn't happen
  • Opening links in the same tab, it doesn't happen

Screenshot below is from "Open Link in New Tab" on dailytech.
ublockfirefoxmobilewrongorder

Screenshot below is from opening link, polygon.com, from 3rd party app ( Pushbullet ).
ublockfirefoxmobilewrongorder2

@gorhill

Seems related to #1019, which might have been fixed by #1021.

@my-password-is-password

It does seem like this issue is fixed with 0.9.1.1-dev.1: Merge pull request #1021 from AlexVallat/master

Edit: Hmm.... With the new 0.9.1.1 the 1st pary hostname still gets sorted with the rest.

@my-password-is-password

Doh. It was one of my other addons fucking things up. Sorry

TabsInForeground
https://addons.mozilla.org/en-us/android/addon/tabsinforeground/

@gorhill

I had an emergency fix to do, so 0.9.1.1 became the official release, which is 0.9.1.0 + the emergency fix.

So now I have to go back to what we were doing. Next dev built will be in 0.9.1.2.

@my-password-is-password

@gorhill Don't go back! Disabling TabsInForeground is the fix.

@gorhill

How could TabsInForeground influence the content of the popup? I suspect the problem was fixed by #1021, all the symptoms match: the page hostname for the tab was not the right one.

@my-password-is-password

I have no idea but when I disable TabsInForeground and manualy click to switch tab, it works.

Btw when using Dev build: use at your own risk, theres 3p-filters.js error. FF mobile and Desktop.

ublock3pfiltersjs

ublock3rdpartydashboard

@gorhill

What is 1561a34d-321a-4d53-8414-d9a410e33053? Another extension?

@my-password-is-password

I think so. That was an old screenshot from earlier today. I opened up the console just now and there was only that one 3pfilters.js error.

@gorhill

It looks like another extension is trying to access uBlock's page, and the browser fires a standard warning that it's not allowed.

@my-password-is-password

Cool, the latest dev build 0.9.1.2-dev.2 works even with TabsInForeground enabled. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.