Skip to content

Loading…

Workaround #1001 for Fennec breaks Google Hangout extension #1025

Closed
gorhill opened this Issue · 2 comments

1 participant

@gorhill

As reported in Chrome store feedback:

when uBlock is active in current window Hangouts Extension loads to an error message saying it's blocked by an Extension. Disabling uBlock in the current window allows it to reload, enabling it again block it again. Silly behavior... obviously uBlock shouldn't be blocking access to other third party Chrome Extensions, just the content on the page.

Fixing.

@gorhill gorhill changed the title from Workaround #1001 for Fennec break Google Hangout extension to Workaround #1001 for Fennec breaks Google Hangout extension
@gorhill gorhill added a commit that referenced this issue
@gorhill gorhill this fixes #1025 1d3dd12
@gorhill

Fixed in 1d3dd12.

@gorhill gorhill closed this
@gorhill

Now that I have a bit more time... The problem was because for whatever reason Google Hangout is created without a main_frame. Thus as per #1001, uBlock would assign the URL of the last seen main_frame as the main frame of Google Hangout, and for those who happen to block 3rd-party frames, this would cause Google Hangout subframe to be blocked.

So the workaround to the workaround is to limit the lifetime of the last seen main_frame. I just set half a second for now, it was an emergency fix so I had to come up with something quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.