Skip to content

Loading…

Options-only filter is not working #1038

Closed
LordJZ opened this Issue · 6 comments

3 participants

@LordJZ

ABP allows omitting the actual filter content, leaving $ options only.

Example:
$script -- disables all scripts
$script,domain=google.com -- disables all scripts on google.com
$script,third-party,domain=google.com -- disables all third-party scripts on google.com

These work in ABP, don't work in uBlock.

Firefox 36, uBlock 0.9.1.0. For testing, create $script filter and head to any javascript-using website e.g. facebook.com.

@LordJZ

I see, but uBlock supports filters with options (like ||google.com^$script) and claims to support ABP syntax.

@LordJZ

Why should I? uBlock claims to understand ABP syntax. If uBlock wants to use a different approach for some kinds of filters, that's fine, translate ABP syntax to something else.

@gorhill

Yes, the asterisk is not supported, i.e. *$script. Dynamic filtering is by far best to deal with this kind of filter: it can be easily toggled on/off, locally/globally.

I have no problem implementing this however. I will, mostly because of users importing their filters from another blocker.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #1038 d1a1e19
@gorhill gorhill closed this in d1a1e19
@LordJZ

Ooh, thanks. Confirmed working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.