Skip to content

Loading…

chromium 19px browserAction icon is fuzzy #1049

Closed
beaufortfrancois opened this Issue · 8 comments

4 participants

@beaufortfrancois

As you can see, vertical and horizontal edges are not as sharp as they could be. Do you mind sharing the source so that I can update the 19px png icon?
I'm not sure if you use SVG, that's why I'm asking.

screenshot 2015-03-19 at 10 06 11 am

Last, but not least, this is a great project! Thank you!

@my-password-is-password

https://github.com/gorhill/uBlock/blob/3c325442fcc73b673df20a7725ac1568857a4017/doc/img/ublock.svg

Don't know if that is the source file but the fuzzy part is the white border when the image get shrunk.

@gorhill

the fuzzy part is the white border when the image get shrunk

Yes.

The source is https://github.com/gorhill/uBlock/blob/master/doc/img/ublock.svg.

The border is 4-pixel wide when the icon is 128-pixel wide (4/128). This means ~0.5 pixel for 19-pixel wide. Setting the border to 1/19, translate into 8/128, which means a rather different icon than the reference one, and being as close to the reference one supersede not having sub-pixel rendering.

Please, do not submit pull requests, I am done spending time on this.

@gorhill gorhill closed this
@harshanvn

@gorhill
Just wanted your opinion. Is below whitish border expected? It used not to be the case with earlier versions..
ublock is correct

@gorhill

Is below whitish border expected?

It's exactly a 0.5-pixel wide border. Expected.

@harshanvn

Hmmm..OK.
One last question reg. this, and the border color should be in white color? Is it not supposed to be red or whatever ublock icon color is...it looks rather weird.

@gorhill

It's not white. It's in between red and white, because it is a 0.5-pixel wide white border when uBlock's icon is rendered at 16-pixel.

@my-password-is-password

Would these be ok? I know you hate this issue. Sorry.

icon19.png
icon19

icon19-off.png
icon19-off

Heres what it looks like on a black theme.
ublockicon19onblacktheme

Current icon19 on a black theme.
ublockcurrenticon19onblacktheme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.