Skip to content

Loading…

Tabs being closed automatically #1051

Closed
juvogel opened this Issue · 13 comments

8 participants

@juvogel

Running version 0.9.1.1

When I click on some links it automatically closes the tab. When I disable ublock thats when this behavior stops.

Example link:
http://ib.adnxs.com/clktrb?id=386368
This link does not close if pasted directly into the browser but when clicked from a link it closes. (Link originally on the Microsoft website, sliding gallery).

@gorhill

Browser/version? Etc. ("Please review the guidelines for contributing to this repository")

@mlindner

I'm also experiencing this.

URL https://www.reddit.com/r/WTF/comments/2zlf1h/the_strangest_constipation_ad_youre_going_to_see/
If I visit this URL by clicking on it from reddit's front page then it closes the tab. Visiting this URL normally does not close the tab.

Google Chrome Version 41.0.2272.89 (64-bit) on Mac OS X 10.8.5

@iczman

Same here with above two links.

Chrome 41.0.2272.101 (64-bit) on OS X 10.10.2

@gorhill

"Please review the guidelines for contributing to this repository"

@mlindner

Your requested information has been given. What is missing? I only started using ublock yesterday, if the plugin is this buggy and support this bad I'm going to be switching back to Adblock for a while. I just had another unrelated page close on me.

@offhub

What is missing?

  • Preferences Different From Defaults
    We recommend a screenshot — include any filter lists you enabled/disabled, whitelisted sites, etc.

  • Other Extensions

@kurtextrem

I can confirm this. Disable uBlock on google search results, google after "superdry" and click the text ad. It redirects to the url and closes the tab immediately.

@gorhill

@kurtextrem I can repro. Investigating.

@gorhill gorhill added investigating and removed need feedback labels
@gorhill

Fixed #510 with 12d2ab5. As far as I can tell this fixes gorhill/uBlock#1051 (comment) ("superdry" case).

I wasn't able to reproduce the other cases so I can't tell if 12d2ab5 fixes them.

@gorhill gorhill closed this
@gorhill gorhill removed the investigating label
@chway

I have the same problem with the latest dev build. When I try to open a link in a new tab (in background), the new tab close automatically. It happen, when I try to open a link from reddit to imgur (not all of them), for example: http://imgur.com/a/0jg9d

Version: 0.9.2.0-rc.0
Browser: Opera 29.0.1795.14 (dev)
OS: Windows 7 64-bit
Other extensions: BetterTTV, Download Chrome Extension, F.B. Purity for Facebook, Google Dictionary (by Google), Imagus, LastPass, Reddit Enhancement Suite

I'm using the default filters list + EasyList Liste FR‎ and the dynamic filtering (Default-deny).

@my-password-is-password

I can reproduce. Using @mlindner reddit link posted above. Middle click it.

It automatically closes the new tab. I'm using uBlock 0.9.2.0 on chromium dev build.

Selected lists:

 Anti-Adblock Killer | Reek
 Fanboy+Easylist-Merged Ultimate List‎
@gorhill

@chway I can reproduce. According to the request log, there are many redirections, and one of them is http://imgur.com/ads?page=inside&main=1&hot=1&time=1426876583, which matches the filter .com/ads?$popup.

@my-password-is-password I can reproduce too. Just to be clear I could not reproduce before 0.9.2.0.

The new code also listen to embedded frames, in order to pass all the tests in #510, I suspect it's what is happening.

@gorhill gorhill reopened this
@gorhill gorhill added a commit that referenced this issue
@gorhill gorhill #1051: test only root frames 04a5786
@gorhill

Fixed with 04a5786.

@gorhill gorhill closed this
@AlexVallat AlexVallat added a commit to AlexVallat/uBlock that referenced this issue
@gorhill gorhill #1051: test only root frames 41a2178
@gorhill gorhill removed the investigating label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.