Skip to content

/uBlock

Loading…

New issue

[Firefox] "Make use of context menu where appropriate" not enforced nor remembered #1057

Closed
gorhill opened this Issue · 3 comments

Labels

None yet

Milestone

No milestone

Assignee

No one assigned

3 participants

@gorhill @Deathamns @baskerville
@gorhill
gorhill commented

As reported on Wilders Security:

0.9.1.1 the setting Make use of context menu where appropriate does not stay set. i uncheck it and restart firefox and it is rechecked again. tried this numerous times. also uninstalled and reinstalled and same thing

@gorhill gorhill changed the title from [Firefox] "Make use of context menu where appropriate" not enforced or remembered to [Firefox] "Make use of context menu where appropriate" not enforced nor remembered
@gorhill
gorhill commented

When de-selecting the setting, this.contextMenu.toggle(value); throws an exception.

Edit: vAPI.contextMenu.remove() is not implemented for the Firefox.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #1057 7e8d2e4
@gorhill gorhill closed this in 7e8d2e4
@Deathamns
Deathamns commented

I thought it wasn't used, my bad.

@gorhill gorhill added a commit that referenced this issue
@gorhill gorhill #1057: cleanup code 4006b99
@AlexVallat AlexVallat added a commit to AlexVallat/uBlock that referenced this issue
@gorhill gorhill this fixes #1057 263243a
@AlexVallat AlexVallat added a commit to AlexVallat/uBlock that referenced this issue
@gorhill gorhill #1057: cleanup code 7d026ed
@baskerville
baskerville commented

I'm experiencing this issue (μBlock 0.9.1.0.1, Firefox 38.0.5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.