Skip to content

Loading…

[Firefox] alignment differences in the pop-up #1121

Open
arthurtiteica opened this Issue · 5 comments

3 participants

@arthurtiteica

There are some differences as how the pop-up appears in Firefox compared to Chrome.

Please look at the following 2 screen-shots.

There are 3 issues:

  • the + and - for every site seems to be cutoff on both sides.
  • the eye is exactly at the right margin in Firefox
  • on the same idea the gray shadow beneath "requests blocked" and "domains connected" is cutoff on the right side.

ublock in Firefox
ublock in Chrome

@gorhill

My Firefox fonts do not look like yours, size-wise.

What OS? Did you customize browser fonts?

@arthurtiteica

This is on Linux x64 with KDE Plasma 5. I'm using Liberation Sans as a global font.

I tried to modify the fonts in the KDE module but it didn't have any effect on Firefox.

I modified the global font hinting. Aside for the fonts getting sharper or blurrier the spacing is the same.

I ran Firefox in a firejail sandbox in order to get a definitely clean profile.

The screen-shot bellow is from that sandbox. As you can see no real changes...

Firefox in sandbox

Further than that I see the same spacing in a Windows 7 virtual machine.

Firefox in Win7

@hotdogman

I thought this issue was a really minor thing, more of an annoyance than an actual issue, but I can reproduce the same thing here. The dynamic filtering panel in chrome has just a few more pixels of space than in firefox.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #1121-2 40cb9a6
@gorhill gorhill closed this in 40cb9a6
@gorhill gorhill reopened this
@gorhill

Fixed issue 2.
There no issue 3.

Now with issue 1, it's more complicated, because it's entirely caused by the font used.

@gorhill

Mine, pretty similar -- Chromium left, Firefox right:

a

@andre-hub andre-hub pushed a commit to andre-hub/uBlock that referenced this issue
@gorhill gorhill this fixes #1121: `allow` rule will no longer affect cosmetic filtering.
the per-site cosmetic filtering switch must be used instead.
b63f55b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.