Skip to content

Loading…

Ignore the dot at the end of the hostname when matching dynamic filtering rules #1251

Closed
chyiz opened this Issue · 0 comments

1 participant

@chyiz

Steps to Reproduce

  1. Enable dynamic filtering;
  2. Goto "nytimes.com";
  3. Wait a moment until the page is fully loaded;
  4. Open dynamic filtering panel.

Symptoms

There is an entry "com." in the dynamic filtering list. It's from some XHR requests made to nytimes.com./ domain.
When I'm having a global block rule for all third party resources, this request is blocked.
According to this article, a domain name with a dot at the end should have the same meaning.

Could we consider them as the same thing in dynamic filtering?

Screenshot:

dynamicfiltering

Info

uBlock version:
   0.9.3.0
Browser and version:
    Firefox 39a2 and Chrome 41.0.2272.118 m
OS and version:
    Windows 7
@gorhill gorhill added a commit to gorhill/uBlock that referenced this issue
@gorhill gorhill this fixes chrisaljoudi/uBlock#1251 c90f085
@gorhill gorhill added a commit to gorhill/uBlock that referenced this issue
@gorhill gorhill this fixes chrisaljoudi/uBlock#1251 f2f4569
@chrisaljoudi chrisaljoudi pushed a commit that closed this issue
@gorhill gorhill this fixes #1251 f2f4569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.