Skip to content

Loading…

Element hiding performance #131

Closed
roshambo1 opened this Issue · 3 comments

2 participants

@roshambo1

I notice blank elements stay on the page long enough to be noticeable. For example http://filehippo.com/download_ccleaner near the top between CCleaner and Description/Technical, etc.

These blank elements never appear on other adblock extensions but they are slower to load the page overall. Could ublock in the future never show these blank elements without slowing down page loading?

@gorhill

Could ublock in the future never show these blank elements without slowing down page loading?

It works already for filters which are domain-specific: these can be applied before the primary DOM is loaded.

Maybe I could come up with a heuristic to auto-generate internally domain-specific filters. So the first time there would be a probability the glitch is noticeable, while thereafter it would no longer be (as long as the extension is not re-launched). That would be the best compromise between performance/efficiency and no-glitch cosmetic filters.

@roshambo1

Would be interesting to try if it's not much work.

@ghost

I too am having this issue.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #131 ef289bc
@gorhill gorhill closed this in ef289bc
@gorhill gorhill removed the fixing label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.