Skip to content

Loading…

CSS error (typo?) in dashboard.css #1320

Closed
AlexVallat opened this Issue · 3 comments

3 participants

@AlexVallat
Collaborator

Originally reported in #1315 (comment) but not related to that branch.

looks like dashboard.css ought to be color: inherit; not inherited?

Possibly something wrong with about.css too? My css-fu is not strong enough to be sure about that, though - I'm not sure exactly what's going on there.

@gorhill

Yes, inherited is wrong, it's supposed to be inherit.

@gorhill gorhill added a commit to gorhill/uBlock that referenced this issue
@gorhill gorhill this fixes chrisaljoudi/uBlock#1320 fa7106a
@chrisaljoudi chrisaljoudi added a commit that closed this issue
@chrisaljoudi Fixes #1320 6e99250
@chrisaljoudi

Yes, that was wrong. With about.css, that seemingly-odd "name" should get replaced with left/right/etc. at compile-time.

@AlexVallat
Collaborator

@chrisaljoudi Do you mean that this is something that should be added to the compile-time scripts, or that it is something they are supposed to be doing already but are not? Looking inside the released .xpi, it isn't happening at the moment. Not that the loss of a small amount of padding is a big deal, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.