Skip to content

Loading…

could not support certain ABP rules #145

Closed
renyouguo opened this Issue · 3 comments

2 participants

@renyouguo

e.g.
~dsjunshi.com##div[id^="ad_thread"]

@gorhill

Need to support "negative" domains for element hiding rules, currently not supported.

No such rules in EasyList EasyPrivacy, however many in Fanboy's lists.

If I understand correctly, ~dsjunshi.com##div[id^="ad_thread"] is equivalent to dsjunshi.com#@#div[id^="ad_thread"]. If so, then fixing this is trivial. I wonder why exception filters were not used rather than having yet another syntax for the same result.

Correction: it is actually equivalent to two rules: dsjunshi.com#@#div[id^="ad_thread"] and ##div[id^="ad_thread"].

@renyouguo

This rule come from EasylistChina.

@gorhill gorhill added the fixing label
@gorhill

Will take the opportunity to do some re-factoring.

@gorhill gorhill closed this in c6b7dfa
@gorhill gorhill removed the fixing label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.