Skip to content

Loading…

"Adblock Warning Removal" list doesn't seem to like uBlock anymore #213

Closed
Mikey1993 opened this Issue · 5 comments

2 participants

@Mikey1993

Some change in uBlock along the way (It worked before, as I had a cache of these rules) broke the "Adblock Warning Removal" list,
and now uBlock doesn't seem to be able to parse it by entering:
https://easylist-downloads.adblockplus.org/antiadblockfilters.txt
in the "Custom" category.

uBlock just seems to wait some seconds (transparent foreground) and then reports 0 in use out of 0 rules.

@gorhill

Works from here. If the URL is not reachable, it will time out after 15 seconds and of course no filters will be accounted for it. Sometimes https://easylist-downloads.adblockplus.org times out, for whatever reason.

Edit: Just to add to this, if ever the content of the URL was previously cached, if the URL can't be reached during an update, the cache of the old version will be kept as a fallback.

@gorhill

I noticed that it takes a while though before the server responds when I try https://easylist-downloads.adblockplus.org/antiadblockfilters.txt directly in the browser.

@Mikey1993

Yeah, you are right.
For mysterious reasons it's now working for me in uBlock..

But before that, when I was able to access
https://easylist-downloads.adblockplus.org/antiadblockfilters.txt
via the browser (but not uBlock),
it was less than 15 seconds, so I don't think that uBlock really waits 15 seconds before cancelling the request.

@gorhill

I don't think that uBlock really waits 15 seconds before cancelling the request

https://github.com/gorhill/uBlock/blob/master/js/assets.js#L210

Note that it won't wait 15 seconds when the server sends an error response, so maybe the server was sending an error code.

@Mikey1993

I see, seems like we will have to live with the assumption that it was indeed 15 seconds.
Time flies while having fun with bugs :)

@Mikey1993 Mikey1993 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.