Skip to content

Loading…

Individual Resources No Longer Blocked #240

Closed
spaghetti2514 opened this Issue · 2 comments

2 participants

@spaghetti2514

Commit 102dc8b broke blocking of individual resources

To reproduce:
Checkout 987e26e
Add filter entry www.zombo.com/inrozxa.swf
Visit www.zombo.com
Page should be blank, as the swf content was properly blocked

Checkout 102dc8b or later
Visit www.zombo.com with the same filter entry in place
swf file is not blocked

Have confirmed with a javascript file on a less accessible site as well

@gorhill

You're right. I couldn't reproduce at first because I had more local changes and the problem doesn't show with these. Investigating.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #240 0bd6e48
@gorhill gorhill closed this in 0bd6e48
@gorhill

Oops, the order of some statements were wrong.

In general, I advise against using "live" version of the repo, as it happens I use the repo as a backup device when I make a lot of changes, i.e. I can't guarantee the extension will always be in a good state, but in truth I am actually happy to see it is used, as appreciate the testing before even a release candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.