Skip to content

Loading…

Mutation observer for attributes. Maybe. #248

Closed
gorhill opened this Issue · 0 comments

1 participant

@gorhill

Not decided whether I will implement this, depends how much not having this causes issues.

For instance, normally uBlock should have been affected as well by the issue raised there: https://adblockplus.org/forum/viewtopic.php?f=2&t=25103.

But it is not, because the attribute title is set after the node is added to the DOM. Although in this case it was a blessing, I suspect it may well happen that some cosmetic filters are not enforced because an attribute on which a specific filter depends may be set after a node is added (the current mutation observer only look for added nodes).

This would need careful implementation to minimize as much as possible the added overhead.

@gorhill gorhill closed this
@AlexVallat AlexVallat pushed a commit to AlexVallat/uBlock that referenced this issue
@gorhill gorhill this fixes #248 and other related cases 4c9d3f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.