Skip to content

Loading…

Opera store: "Doesn't seem to block pop-ups" #297

Closed
gorhill opened this Issue · 6 comments

1 participant

@gorhill

I am not aware of any problem with uBlock not being able to block unwanted popups.

If any of the reviewers read this, please give me a specific case where this happens. I can't look into and fix things with a specific scenario on how to reproduce the problem.

@gorhill

The popup in #58 is still properly foiled, so I need a specific case where it is not working.

@gorhill

I could reproduce on Opera 24 (I had tested with Chromium, I didn't expect a difference with Opera): http://playhd.eu/9zkcjejdcr6x.

Investigating.

@gorhill

I see... In Opera, unlike Chromium/Chrome, there is no referer HTTP header. I have to find out why.

@gorhill

I get this in Chromium (does block popup) for the above link, until I reach the player which can be played:

referee="http://playhd.eu/alabala.html"
    referrer="http://playhd.eu/9zkcjejdcr6x" traffic.js:166
referee="http://playhd.eu/alabala.html"
    referrer="" traffic.js:166
referee="http://playhd.eu/jiji.html"
    referrer="http://playhd.eu/9zkcjejdcr6x" traffic.js:166
referee="http://playhd.eu/9zkcjejdcr6x"
    referrer="http://playhd.eu/9zkcjejdcr6x" traffic.js:166
referee="http://playhd.eu/jiji.html"
    referrer="http://playhd.eu/9zkcjejdcr6x" traffic.js:166
referee="http://playhd.eu/alabala.html"
    referrer="http://playhd.eu/9zkcjejdcr6x" 

And this is Opera (doesn't block popup):

referee="http://playhd.eu/alabala.html"
    referrer="http://playhd.eu/9zkcjejdcr6x" traffic.js:166
referee="http://playhd.eu/jiji.html"
    referrer="" traffic.js:166
referee=[ad ridden popup page]
    referrer="http://playhd.eu/jiji.html" traffic.js:166
referee=etc
@gorhill

Looks like I might have to implement a fallback mechanism for Opera: https://developer.chrome.com/extensions/webNavigation#event-onCreatedNavigationTarget.

@gorhill gorhill added fixing and removed need feedback labels
@gorhill

Works handsomely, and as an extra, this also solves #91.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #297 and #91 c7eebec
@gorhill gorhill closed this in c7eebec
@gorhill gorhill removed the fixing label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.