Skip to content

Loading…

Incorrect number of blocked ads on gospelherald.com #318

Closed
anticafe opened this Issue · 7 comments

2 participants

@anticafe

I try to open an article on gospelherald.com/ (http://www.gospelherald.com/articles/52872/20141013/october-google-event-expected-to-announce-release-of-nexus-x-6-and-nexus-9-tablet.htm) and realize number of blocked ads continue increasing, from 1 to 5, to 10,..., then 562.

Is it any wrong there? I don't believe there are so many ads on this page.

@gorhill

It stops at 35 on my side, using default filter lists.

  • What version of Chromium (or derivative)?
  • What filter lists you have enabled?

As an aside and to reiterate, uBlock blocks more than just ads, and actually more than often it will end up blocking less ads on a single page than other stuff like trackers/data miners et al. For example, at this page, the counter keep going up and up, not because of ads, but because of the obnoxious attempt at tracking/data-mining.

@ghost

35 here also.

@anticafe

I'm using Chrome Version 37.0.2062.124 m on Windows 7.

This morning I try to load that page again and see there are 33 ads blocked. Try again, then there are 25. Try reload again, is 39.

Currently my Ads setting has EasyList‎ (adblockplus.org), Peter Lowe’s Ad server list‎ (yoyo.org) and VIE: Fanboy's Vietnamese‎ (www.fanboy.co.nz/fanboy-vietnam.txt) enable.

@gorhill

The only places where the network request count is incremented is when chrome webRequest API's onBeforeRequest() is called, and when inline scripts are blocked through dynamic filtering. There is no other place in the code.

So essentially this means that there were really net requests matching the block count -- there is no other way for the count to go up. If it happens again, I suggest you open the dev console of the web page where it happens (Ctrl-Shift-i) and take note of the blocked connection error messages to find out what URL is blocked.

@gorhill

I have been trying to repro without success. I was thinking... What other extensions do you have installed?

@anticafe

Well, this morning I force update uBlocker update all its 3rd-party filter, then try to reload gospelherald.com again, and see there are 32 ads blocked. Till now I cannot reproduce to have 562 ad blocked as before. I think this issue might be already fixed.

@gorhill gorhill closed this
@ghost

I see count increasing by 1 on this page: https://github.com/gorhill/uBlock/issues by clicking on an issue, then back button, the clicking on an issue again.
With firefox 35.0.1 and uBlock 062afe4
But I guess that makes sense because it's treating the page as one contiguous page with 3rd party requests happening with each click, due to its scripts.
For example it doesn't happen when clicking multiple times on Explore at top of this page https://github.com/explore but it does happen when doing it on All (or Showcases).

What I was trying to find out is why, the counter is always 0 or 0% when holding uBlock's popup open and clicking its refresh button, after having changed something in that matrix (I am an advanced user option must be active to see matrix). Reopening it shows the correct number though.

after having clicked the big refresh button(in uBlock's popup):
afterrefresh

after closing and reopening the popup:
cloreopened

The icon counter (of 1) is updated successfully though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.