Skip to content

Loading…

I believe the remote location of the Icelandic list was removed by mistake #326

Closed
samolesen opened this Issue · 3 comments

2 participants

@samolesen

In 69b6027 the remote location of the Icelandic list was removed.
In release 0.7.0.7 it is mentioned that is was because a user (me) reported it was whitelisting google ads. I was only mentioning the Danish list (which correctly had its remote location removed already), so the removal of the Icelandic list might have been a mistake, unless it was removed for some other reason.

There have apparently also been some progress with the Danish list now. The maintainer have today removed the whitelist of google ads from the Danish list. Whether it can trusted in the future as a remote location is another issue..

@samolesen samolesen changed the title from I think the remote location of the Icelandic list was removed by mistake to I believe the remote location of the Icelandic list was removed by mistake
@gorhill

You're right, I got really confused today it seems. I see I had removed the entry already with 3248b8d (and properly without leaving a trailing comma), I forgot I had done so.

I will put it back.

@gorhill

Wait a minute, I was right to remove the entry, I just got confused as to why I did when I scrambled to explain what happened while in panic mode.

There is a bug in the Icelandic list, which I fixed locally and I don't want people to suffer the bug, hence I have to remove the URL address of the remote version. I notified the author about the bug a while ago but it's not getting fixed.

The bug is: gaflari.is#div(class*=auglysingaplass)
My fix: gaflari.is##div[class*="auglysingaplass"]

The bug is that it is not a valid filter syntax and neither a valid CSS selector, I expect this will cause the content script to emit an exception and prevent uBlock from functioning properly.

@samolesen

I did wonder whether you just mixed up two independent issues ;)

@samolesen samolesen closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.