Skip to content

Loading…

statistics tab in RTL (Hebrew) is uncomfortable to view and interact #375

Closed
Mikey1993 opened this Issue · 6 comments

2 participants

@Mikey1993

When viewing the statistics tab in RTL language (Hebrew, for example), the data that should only appear as LTR (like URLs, filter) is aligned as RTL.

2 Issues:

First:

The data that should be LTR:
1. Filters - Appear backwards and hard to copy.
2. URLs - Appear on the right side of the cell, and hard to copy.
3. Types - IMO should have the strings on Crowdin, but as of it now.. oh well...

The data that should stay RTL:
1. Headers

Second:

I also think that all the data should be placed in the center of it's cell (except domain and logAllowed/logBlocked headers), without any use of explicit margins and paddings.

Simple text-align: center ?

@gorhill

Ugh... I wanted to see the bug and here is what I experienced: https://code.google.com/p/chromium/issues/detail?id=432088

Don't you have this problem?

@Mikey1993

@gorhill Nope, I am on Canary channel and I don't see this issue (and never did), but it's unrelated to this issue I presume..

@gorhill

Ok for Filters and URLs, fixed.

For Types, these can be used in a filter as is, which would not work if translated.

For alignment, I refer the current way, URLs/filters anchored to the right.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #375 1ba3142
@gorhill gorhill closed this in 1ba3142
@Mikey1993

@gorhill
First of all, thanks for fixing this.
Second, can you please elaborate about the reason behind not translating Types? I don't really get to the bottom of your sayings..
I believe it should be consistent as done with the translation of uMatrix.

@gorhill

In uMatrix, types in "My rules" are not translated, as they are part of the syntax.

In uBlock, types can be part of the syntax too: ||example.com^$image. So if someone wanted to create a net filter out of a request in the log, I believe it is better if they can see the type which can be used as is to craft a filter.

@Mikey1993

I see.
Thanks for clarifying this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.