Skip to content

Loading…

Report the filter list containing the filter of a blocked request #43

Closed
gorhill opened this Issue · 4 comments

2 participants

@gorhill

I saw it as a separate issue, it was originally reported in #12 by @zerkms:

Just as a minor addition: it also might be helpful to show not only the exact filter applied, but also a subscription name that it came from.

@gorhill

Ideally, the exact filter list and line in that list would be great.

@gorhill

Not a straightforward feature. If uBlock were to keep track of where each filter originate exactly, it would gain a good chunk of memory and CPU footprint. Not going to happen. However, another solution is to reverse lookup, which in the current case is completely acceptable, since it's only a UI thing, and only for users which have an interest in that kind of information.

@gorhill

With the compiled filer lists in 0.8.8.5, this feature become closer to feasibility.

A compiled filter list could have an extra field which would be the offset at which the original filter is to be found in the original raw filter list.

It should be possible to infer a compiled filter entry from any live filter. So it would be a matter of finding the inferred compiled filter entry in any of the compiled filter lists which have been used to load the current filters. Since we are dealing with normalized entry, a plain string search can be used, fast.

But still, this will have to be on-demand only, as pointed out somewhere above. But more technically feasible now.

@andre-hub andre-hub pushed a commit to andre-hub/uBlock that referenced this issue
@gorhill gorhill this fixes #43 9752c49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.