Skip to content

Loading…

Github Issue #452

Closed
gpedro opened this Issue · 9 comments

4 participants

@gpedro

gh problems

I've tested and is caused by uBlock

I'm using Chrome 39.0.2171.95 (64-bit), OSX 10.9.5

@gorhill

I can't reproduce.

Repro steps? Filter lists? Custom filters?

@gpedro

Steps:
1 - disable/enable* uBlock
2 - close the current tab from github
3 - open new tab from github

  • (enable) ? buggy : works

I recently installed, do not set anything.

@dashed

I experienced the same problem with a vanilla installation on Chrome.

The problem seems to go away when you disable "Fanboy’s Annoyance List‎".

@gorhill

Yes, there is a ##.social-count cosmetic filter in "Fanboy's Social Blocking List", so the count widget should dispappear as per this 3rd-party filter list. I am trying to understand why it does not disappear on my side.

Edit: ok there is an exception filter: github.com#@#.social-count. So now I would need to investigate then why it's not working for OP. I still cannot reproduce.

@dashed

@gorhill The issue in question doesn't occur all the time (at least for me; but it was annoying). I was going to report this issue, until I realized it was a 3rd-party filter list. So I thought it was out of scope. I'm unable to discern the exact reproducible steps.

As far as I can tell, clicking on links that are part of the SPA of GitHub (i.e. no hard refresh) doesn't seem to create the issue.

@gorhill

The only way I can think how this could happen is if the generic filters arrive to the content script before the specific ones (the ones specific to a hostname). I am currently assuming the contentscript-start.js is always executed before contentscript-end.js. But given the symptom described here, this may not always be the case by all appearances.

@gorhill

Ok I can reproduce on my very old laptop, I can investigate now.

@Narno

I encounter the same problem, but I am unable to reproduce systematically. It's erratic...

uBlock default settings + "FRA: EasyList Liste FR" enabled.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #452 baa0fee
@gorhill gorhill closed this in baa0fee
@gorhill gorhill added a commit that referenced this issue
@gorhill gorhill code review for #452 4c7533b
@dashed

Can confirm that fix seems to work.

@andre-hub andre-hub pushed a commit to andre-hub/uBlock that referenced this issue
@gorhill gorhill this fixes #452 a9089b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.