Skip to content

Loading…

Disappearing Gmail Labels #456

Closed
mbadolato opened this Issue · 17 comments

2 participants

@mbadolato

Earlier this week I noticed that 4 of the labels in Gmail were blank. They showed no text, however they were empty placeholders (and the blank space could still be clicked on and take me into that label/folder).

The four were my labels for Facebook, LinkedIn, Twitter, and Google+. If I went into label management and renamed them, they would show up (say Facebook -> Facebook1). But then renaming them back caused them to blank out again.

missing_labels

I decided to check out settings in uBlock since I had just switched to it from AdBlocker Plus right around the time that I noticed the issue. When I tried disabling the Fanboy's Social Blocking List plugin, I discovered that was the cause. With it disabled, the labels showed up again.

Not sure if this is a uBlock issue or a Fanboy's Social Blocking issue, but figured I'd let you know.

@gorhill

I see exception filters in "Fanboy's Social Block List":

mail.google.com#@#a[title="Facebook"]
mail.google.com#@#a[title="Google Plus"]
mail.google.com#@#a[title="Google+"]
mail.google.com#@#a[title="LinkedIn"]
mail.google.com#@#a[title="Pinterest"]
mail.google.com#@#a[title="Twitter"]
mail.google.com#@#a[title="Youtube"]

So the issue is probably related to issue #452, which is fixed in version 0.8.2.4 (which I posted minutes ago to the Chrome store). Looks like the issue may have affected more users than I thought.

If you can confirm it is fixed once you get 0.8.2.4.

@mbadolato

@gorhill Thanks for the quick reply

Not fixed. I installed 0.8.2.4 (confirmed on my extension screen), re-enabled the plugin, and the labels blanked out again. I did try quitting and restarting Chrome, just in case uBlock needed it.

@gorhill

Not a Gmail user here, but I have an account for testing purpose. Where are these labels?

@gorhill

Never mind, I see it -- or rather, I can see it's not visible.

@mbadolato

Settings->Labels and create them. They'll appear on your left-hand side where Inbox, Drafts etc are

@mbadolato

Hah github comment/reply race condition :smile:

@gorhill

Ok I see the problem, will fix.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #456 33d73b3
@gorhill gorhill closed this in 33d73b3
@mbadolato

Great! I'll test it as soon as the new version hits the Chrome store.

@gorhill

Just posted to Chrome store, should be there after 60 minutes.

@mbadolato

OK, I'll check back in a bit

@mbadolato

Confirmed working for me now. Thanks much for the speedy fix and for creating a great extension. Cheers!

@mbadolato

@gorhill I spoke to soon. I just quit Chrome, reopened, and the labels are gone again :frowning:

@mbadolato

Interesting. If I disable the plugin and refresh Gmail, I see the labels. If I then enable it and refresh it's still ok. But if I then quit and reopen chrome, the labels are gone.

If the plugin is enabled and the labels don't show (after the quit and restart), and I disable the plugin and refresh, the labels come back.

@gorhill

Could you force an update of your filter lists? (Purge all caches)

@gorhill gorhill reopened this
@gorhill

Never mind I see it. There is something else happening then. At launch, the content scripts are injected manually, so it seems this is where there is a problem.

@gorhill

Yes, it's related to injecting the content scripts manually, different problem than the one solved above.

Since fix to #426, maybe not injecting the content scripts manually is now an option...

@gorhill gorhill closed this in 2a7e9f8
@gorhill gorhill added a commit that referenced this issue
@gorhill gorhill code review for #456 2d05d51
@mbadolato

Looks like that did it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.