Skip to content

Loading…

No short description for My Rules tab in the dashboard #513

Closed
Mikey1993 opened this Issue · 6 comments

3 participants

@Mikey1993

Might be confusing for novice users, who didn't enable the "I am an advanced user" option to see this tab and don't understand what it supposed to be.

A thought:
Can we generate this tab only if the "I am an advanced user" is checked?
If not, it will have some text saying that this tab is for advanced users and can be seen by enabling this option?

@gorhill

Yes, the hint, I forgot to add it in messages.json, it's in the HTML.. So how about:

Rule syntax: source destination type action (Documentation)

"Documentation" would link to https://github.com/gorhill/uBlock/wiki/Dynamic-filtering:-rule-syntax.

For the "My rules" tab, I was planning to hide it, but then I thought that a user may still want to see the rules even after deactivating dynamic filtering (dynamic filtering is disabled when turning off "advanced users")

@Mikey1993

The hint (basic syntax explanation) above should be good enough for people to be interested in going to the documentation, but I think that you should follow the design pattern as with the other tabs in the dashboard, with at least a sentence before this hint explaining that this list is for advanced users and is only becoming active if they check the "I am an advanced user" checkbox.

@chrisaljoudi

PR #538

@Mikey1993 Mikey1993 closed this
@Mikey1993

Actually, No text in the latest FF version on the My Rules tab.
Reopening.

@Mikey1993 Mikey1993 reopened this
@gorhill

It shows for me: v0.8.5.7. The text should be there, there is nothing platform-specific in the resolution of that bug.

@Mikey1993

That's very strange, text is shown now on FF for me.
Might be some Nightly shenanigans.
Closing, again.

@Mikey1993 Mikey1993 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.