[firefox] about:healthreport cannot be opened in an existing tab

[harshanvn]

When tinkering with healthreport now, i just saw that you cannot open below url in an existing tab -
"about:healthreport"

Steps:
1. open google.com
2. Then open "about:healthreport"

Then you would see google in the popui:)

Edit: I had almost this or similar issue during early preview stage, but was not able to figure out at that time. It came on fudzilla.com. (was seeing previous website entries in the dynamic filtering popui). Just wanted to bring it up.

[Mikey1993]

I can't reproduce with the latest version (0.8.5.5) on FF Nightly (v38).
The page opens fine.

[harshanvn]

Am on Firefox Stable (Windows 8.1, enabled dev theme, from about:config), using 0.8.5.5

browser.devedition.theme.enabled:true devtools.theme: dark

@Mikey1993 Have you set dynamic filtering same as mine?

[gorhill]

I could reproduce on Firefox. However I could not reproduce on Chromium (I used about:blank). Will keep investigating.

[harshanvn]

And this doesn't happen with about:config

[Mikey1993]

Actually, I do see some strange behavior if navigating to the "about:healthreport" from an existing tab and loading from a new tab, but I still can't get the page to draw blank and the popup doesn't include anything from google.

Edit: Got the blank page, but don't have any google requests in the popup.

[gorhill]

I see that uBlock's vAPI.tabs.onNavigation is not called when about:healthreport is loaded in the tab, so this means uBlock has no way to know the tab changed. Probably something trivial but I will CC @Deathamns, he is likely to know immediately where is the quirk.

[gorhill]

Yes, I see onNavigation() is called only for http[s] pages, while it should call for whatever so that uBlock can unbind it's data structure internally. This seems a trivial fix, but I prefer to let @Deathamns deal with it just to be sure there is no non-trivial consequences to the fix.

[harshanvn]

Ok. Yes, this is not a big deal. It can definitely wait.
What i am wondering is, how come about:config is working. Perhaps onNavigation is called for it?

[gorhill]

It should not, and I confirm about:config exhibits same problem.

[Deathamns]

@gorhill Correct. If I recall correctly, I put that check there because pop-up blocking. I'll write a comment to the pop-up blocking issue...

[gorhill]

Looks like this is fixed in 0.8.6.0, probably as a result of fixing #105.

[harshanvn]

Yes. This is working fine now.
Not sure, if you want this to be closed, I will leave it for your choice.
Thanks.