Skip to content

Loading…

[Firefox] Element picker: pressing escape to exit #530

Closed
rrooij opened this Issue · 5 comments

3 participants

@rrooij

When selecting the element picker mode, you can't quit the mode until you've selected an element. Wouldn't it be nice if it stopped when pressing ESC? It already stops when hitting ESC when the user has already selected an element, but not if the user hasn't.

I tried to implement it myself and saw the method onKeyPress already added as eventlistener. Can the eventlistener be applied earlier on? I tried with no luck.

Firefox user btw.

@gorhill

Works on Chromium, so this is specific to Firefox.

@gorhill gorhill changed the title from Element picker: pressing escape to exit to [Firefox] Element picker: pressing escape to exit
@rrooij

Works on Chromium, so this is specific to Firefox.

Ah, that's a pity.

@gorhill

I didn't look, but I suspect it's fixable.

@Deathamns

A window.focus() will fix it.

@Deathamns

Fixed in f1bcc0a.

@Deathamns Deathamns closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.