Skip to content

Loading…

EasyList doesn't block all ads #56

Closed
AratnitY opened this Issue · 9 comments

3 participants

@AratnitY

Due to the way Adblock Plus makes their lists, not all ads get blocked. There is a set of lists for Adblock Edge that allow everything to get blocked. Would it be possible for these to be implemented in the future? (Apparently some people have issues using them, could they be replicated by removing all the exceptions? As an optional list of course.)

https://bitbucket.org/adstomper/adblockedge/issue/78/adblock-edge-is-using-adblockplusorg

@AratnitY AratnitY changed the title from Filter Reqests to Not all ads are being blocked
@AratnitY AratnitY changed the title from Not all ads are being blocked to EasyList doesn't block all ads
@kurtextrem

I think those are to make some websites work which would break otherwise.

@gorhill

Yes, it's their purpose. I originally thought wrongly they were to allow ads on some sites, but it is really to unbreak sites -- thought there might be a lot of obsolete rules overall, including in the exception rules.

@AratnitY

Yes however they still let "acceptable" ads through and that can't be disabled. (As well as things like Hulu and the like.) I would just like the option of having them available. (Provide a "This will break things warning. If you have trouble use the regular EasyList instead." when someone checks the filter box?)

@gorhill

I think I would prefer the issue here being addressed by issue #6. Issue #6 is a bit of a "challenge" too, not because of code, but because the local storage is limited, and I worry at this point a user could run out of local storage if using a lot of external lists. This is why I am taking my time for #6, but I might address earlier than later now, as the request for such feature comes up regularly.

@AratnitY

That's another way to do it. I was just hoping for something automated because I've never been able to get the ABE No-Mercy lists to even load. (But apparently other people have)

@gorhill

never been able to get the ABE No-Mercy lists to even load

Then this will be a good list to use as test case for when I address #6.

@AratnitY

Maybe you could have in an option that allows for picking of which specific filters we would like enabled/disabled?

@gorhill

Another option could be "Ignore exception filters", with a prominent warning about sites breakage. I just wonder how many users of blockers really long term use that kind of stricter approach. I wouldn't want to start to throw settings in there if there is not a solid demand for it. I don't want to start to create settings at the whim of anybody's personal view, but rather if there is a real user base out there asking for a specific feature. bad idea: there might be "bad" exception filters in there, but we can't just disabled all exception filters, there are not all "bad".

@gorhill

With fix to #6, users can subscribe to their choice of external lists.

@gorhill gorhill closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.