Skip to content

Loading…

[Firefox] Button label with number of blocked requests switches to superscript with red background #579

Closed
gwarser opened this Issue · 12 comments

7 participants

@gwarser

after entering interface customization mode.
Rright click on the button -> Customize and then Exit Customize

up
2

Fx 36b2, uBlock 0.8.5.7

@Betsy25

I can confirm this behavior with FF38.

@Deathamns

Possible fix in 9fe8f41.
Also, now the the browser's default positioning is used (the red icon you see on the screenshot above).

@gwarser

Looks good. Thank you.

@gwarser gwarser closed this
@ekerazha

Occasionally, I still see the red badge in v 0.8.9.1.

@Deathamns

@ekerazha It changes to red permanently, or just for a moment after you did some customization?
If it's permanent, and you're using the default theme, then I don't know.
When it just flashes to red for a moment after customization, then that is normal.

@ekerazha

@Deathamns Permanently and without touching the customization UI.
I'm not sure but it could happen when you recover a browsing session after a browser crash.

P.S.
I tried to deliberately crash Firefox but I couldn't reproduce the issue... I'll look at it when it will happen again.

@gorhill

I've seen this too. It's permanent. But I've been trying to figure what triggers this, no success so far.

@TheSweetLily

Last time my video driver crashed it became red permanently.
Not sure if it can help it any way, but it might give some leads?

@ekerazha

@gorhill I just found a way to trigger it:
1) Resize the browser window until the icon gets hidden.
2) Restore the window size.

@gorhill

@ekerazha Nice one!

Now will be to figure how to fix this. Or it could be argued it is a Firefox bug, not sure.

@gorhill gorhill reopened this
@Deathamns

25d5166. They may be other cases too when the icon is removed/hidden from its area.

@alejandrolemus

Seems OK now in 0.9.0.1 for the resize/restore (I think you can see a really fast color change while restoring the windows size)
Too bad, red was kinda cool :)

@gorhill gorhill referenced this issue in gorhill/uBlock
Closed

icon bug on firefox nightly #55

@gwarser gwarser closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.