Skip to content

Loading…

Consider moving some code used by µBlock.URI to platform-specific side #620

Closed
gorhill opened this Issue · 2 comments

2 participants

@gorhill

Firefox has utilities to parse URL and extract effective domain names using the public suffix list.

Not sure but I am assuming this is faster than the current JS-based solution. So if we move that code to vAPI, Firefox would gain something while the other platforms (Chromium/Safari) would just still rely on the current solution.

But first I would like to find out whether there is a clear gain in using nsIEffectiveTLDService.getBaseDomainFromHost over publicsuffixlist.js.

@gorhill gorhill changed the title from Consider moving µBlock.URI to platform-specific side to Consider moving some code used by µBlock.URI to platform-specific side
@chrisaljoudi

It's unclear whether nsIEffectiveTLDService is supported/works at all in Firefox (I get a deprecation warning when trying code from the documentation you linked) — followed by an error.

@gorhill

Well I ran some quick benchmark and that made no difference. Closing.

@gorhill gorhill closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.