[Safari] µBlock breaks when toolbar icon is hidden

[jochemkeller]

When I remove the icon from the Safari toolbar and restart the browser, µBlock fails to load and appears broken. When I restore the icon to the toolbar and restart everything works again.

Interesting little bug or is this intended behaviour? I would expect it to work even when the icon is not visible (based on experience with other add-ons).

Even so, thanks for a great add-on!

[OMCS]

I can confirm this behaviour occurs on Safari 8.0.3 (OS X 10.10.2 if that's relevant). I'm not sure if it is by design or not but I'd really appreciate the option to hide the toolbar icon.

[gorhill]

I'm not sure if it is by design

No, not by design. uBlock still blocks fine when I remove the button with Chromium.

[fletom]

+1

I hid the icon because the red block count stands out way too much, then uBlock stopped working altogether. Even clicking the preferences checkbox didn't bring anything up.

[chrisaljoudi]

@OMCS @jochemkeller ack. I'm working on some major-ish changes, and this is coming up on my list directly afterwards.

@fletom sorry about that — but FYI, you can disable the badge block count from μBlock's preferences without having to remove the icon.

[jochemkeller]

@OMCS thanks for mentioning OS X 10.10.2 and Safari 8.0.3. I have exactly the same versions and forgot to include!

@gorhill sounds like a bug then? I think it has to do with Safari 8.0.3

@fletom you can disable that right here:

@chrisaljoudi thanks so much!

[chrisaljoudi]

@jochemkeller it is indeed a bug and I think I have a good idea of where the problem is (not core μBlock).

If I weren't on my iPhone, I'd push the fix within a few minutes. :)

[fletom]

@chrisaljoudi and @jochemkeller Thanks for the tip!

[chrisaljoudi]

Fixed with 30f1c9e.

[jochemkeller]

Thanks so much! Eagerly awaiting the release 😃👍