Skip to content

Loading…

[Chromium] Tests #4-8 on http://raymondhill.net/ublock/popup.html are not working #663

Closed
hotdogman opened this Issue · 8 comments

3 participants

@hotdogman

uBlock version: 0.8.6.0 from Chrome Web store
Browser version: Chrome 40
OS: Win 8.1 x64
Tested using the default filter lists.

As the title says, 4 through 8 on http://raymondhill.net/ublock/popup.html are not being blocked.
4 does not close
5 does not close
6 is not empty
7 is not empty either
8 does not close when clicking on test.

https://a.pomf.se/xfypiz.gif

@gorhill gorhill changed the title from Tests #4-8 on http://raymondhill.net/ublock/popup.html are not working to [Chromium] Tests #4-8 on http://raymondhill.net/ublock/popup.html are not working
@hotdogman

6, 8, and 11 fail on Firefox.

@Deathamns

8th should not close when clicking (see #507).
For some of the rest you have to remove the about-scheme and data-scheme entries from the Whitelist.

@hotdogman

8th should not close when clicking (see #507).

Whoops, my bad, should've looked/read a bit more.

For some of the rest you have to remove the about-scheme and data-scheme entries from the Whitelist.

After removing about-scheme and data-scheme from the whitelist, all tests pass on Firefox.
After removing about-scheme and data-scheme from Chrome:
4 and 5 do not automatically close
6 and 7 are not empty, they show the example.com page

@gorhill

@Deathamns I removed about-scheme and data-scheme from default whitelist. I didn't realized the negative side effect to blocking popup.

@Deathamns

@hotdogman
Supporting 4 and 5 probably will need some work in Chrome.
6 and 7 should be supported if you remove the whitelisted schemes, but it seems something is not right there. Maybe vAPI.tabs.onUpdated doesn't fire when opening a window (because if you refresh the popup 6 after it loaded, then the iframe won't load)?

@gorhill You mean you didn't push a commit for it, or just wanted to remove it?

@gorhill

I will push a commit when I am done with the other stuff.

@Deathamns

By the way, this issues is basically a duplicate of #510.

@hotdogman

By the way, this issues is basically a duplicate of #510.

Whoops, didn't notice. My apologies.

@hotdogman hotdogman closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.