Skip to content

Loading…

Can't open datacenter.biathlonresults.com, jQuery was not found. #665

Closed
andrey-budko opened this Issue · 10 comments

3 participants

@andrey-budko

Can't open http://datacenter.biathlonresults.com/ if uBlock is enabled.

JavaScript console:
Error: jQuery was not found. Please ensure jQuery is referenced before the SignalR client JavaScript file.
ReferenceError: $ is not defined.

Works fine with AdBlock Plus

uBlock 0.8.6, Firefox 35

@Mikey1993

Add this exception filter to your "My filters" list:
@@||info$script,domain=biathlonresults.com

@gorhill

It opens fine with default filter lists. What are your filter lists? Custom filters? Etc. Details please, saves time to all.

@andrey-budko

It breaks after enabling
RUS: RU AdList (Дополнительная региональная подписка)‎

Full list of subscriptions I used:

My filters‎: 0 used out of 0
µBlock filters‎: 119 used out of 119
µBlock filters – Privacy‎: 2 used out of 2

EasyList‎ (adblockplus.org): 52 557 used out of 52 593
Peter Lowe’s Ad server list‎ (yoyo.org): 2 402 used out of 2 452

EasyPrivacy‎ (adblockplus.org): 9 739 used out of 9 745

Malware Domain List‎ (malwaredomainlist.com): 1 511 used out of 1 525
Malware domains‎: 17 244 used out of 20 125
Malware domains (long-lived)‎: 2 737 used out of 2 737

Fanboy’s Social Blocking List‎ (adblockplus.org): 11 487 used out of 11 490

RUS: RU AdList (Дополнительная региональная подписка)‎ (adblockplus.org): 6 860 used out of 6 860

@Mikey1993

Right, this is why I was able to reproduce this.
RUS: RU AdList (Дополнительная региональная подписка)‎ is not a list which is enabled by default.

@gorhill

@andrey-budko So you are telling me that ABP with RU Adlist does not have the problem? (I can't try right now as https://easylist-downloads.adblockplus.org/ is down.)

@gorhill

Ok, I could finally try it with ABP and it does not have the problem. This filter is the cause:

||info^$third-party,script

Investigating.

@andrey-budko

With ABP I use «RuAdList+EasyList» preset. It refers to:
https://easylist-downloads.adblockplus.org/ruadlist+easylist.txt

@gorhill

Problem is here: https://github.com/gorhill/uBlock/blob/master/src/js/static-net-filtering.js#L1321

TODO: transforming ^ into * is not a strict interpretation of ABP syntax.

@gorhill

Investigating for best fix. I will experiment with one that I figure could actually increase uBlock's efficiency of the network requests handler -- will benchmark to validate. I will take my time, I don't want to rush things.

Meanwhile, workaround above by @Mikey1993 works.

@gorhill gorhill added fixing and removed need feedback labels
@gorhill

After changes to fix the bug:

µBlock> onBeforeRequest: 0.131 ms (8664 samples)
µBlock> onBeforeRequest: 0.131 ms (8763 samples)
µBlock> onBeforeRequest: 0.131 ms (8839 samples)
µBlock> onBeforeRequest: 0.130 ms (8914 samples)
µBlock> onBeforeRequest: 0.131 ms (8988 samples)
µBlock> onBeforeRequest: 0.131 ms (9033 samples)
µBlock> onBeforeRequest: 0.130 ms (9192 samples)
µBlock> onBeforeRequest: 0.130 ms (9206 samples)
µBlock> onBeforeRequest: 0.129 ms (9324 samples)
µBlock> onBeforeRequest: 0.129 ms (9329 samples)

Also, this was after I moved the start of profiling to the platform-specific code (the earliest entry point into uBlock's code), something I forgot to do with the last results (I will revise the last results to use the results here).

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #665 7a5d09b
@gorhill gorhill closed this in 7a5d09b
@gorhill gorhill removed the fixing label
@gorhill gorhill changed the title from [Firefox] Can't open datacenter.biathlonresults.com, jQuery was not found. to Can't open datacenter.biathlonresults.com, jQuery was not found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.