Skip to content

Loading…

[Firefox] how do I white list all local sites 192.168.*.* #669

Open
TimTechDude opened this Issue · 2 comments

2 participants

@TimTechDude

I have just switched from using ABP 2.6.7.

I used rule "@@||192.168..^$document" to whitelist all local sites to stop interference with router interfaces.
This does not appear to work when placed in "My Filters" (which I checked was enabled)
What am I doing wrong?

Thanks

@gorhill

uBlock does not support the document option, as this is used to disable completely a blocker, and I completely disagree with using a filter to disengage a blocker. What you need to use is a whitelist directive in the Whitelist tab in the dashboard.

However I realize I didn't take into account that the target of whitelisting could be an IP address. Well it would work with an IP address, but what you want is 192.168.*/, and currently a wildcard at the end of a hostname is not allowed (because it would be impossible to create an efficient dictionary).

So I need to extend the whitelisting code to support explicitly IP address, and in the case of IP address, the wildcard need to go at the end, when one is used.

@TimTechDude

Thanks for the fast reply and for all your hard work!
I will just stick a few IP addresses in the whitelist for now, that works fine.

@andre-hub andre-hub pushed a commit to andre-hub/uBlock that referenced this issue
@gorhill gorhill this fixes #668, #669 05ce671
@ahmadassaf ahmadassaf added a commit to ahmadassaf/uBlock that referenced this issue
@ahmadassaf ahmadassaf Merge branch 'master' of https://github.com/gorhill/uBlock
* 'master' of https://github.com/gorhill/uBlock: (125 commits)
  brought information up to date
  interim version for dev build
  this fixes #672
  this fixes #678
  translation work from https://crowdin.com/project/ublock
  vAPI.net.registerListeners(): code review
  translation work from https://crowdin.com/project/ublock
  interim version for dev build
  this fixes #668, #669
  this fixes #667
  this fixes #666
  translation work from https://crowdin.com/project/ublock
  this fixes #654
  translation work from https://crowdin.com/project/ublock
  Update README.md
  Update README.md
  Update README.md
  Update README.md
  Update README.md
  chrisaljoudi#1528: apply fix to element picker
  ...
51d9b2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.