Skip to content

Loading…

µBlock fail, ABP ok #671

Closed
pvlb opened this Issue · 14 comments

4 participants

@pvlb

Not work filter ||http://animevost.org/692х200.swf, in ABP for Firefox ok.

@my-password-is-password

In the request log the url looks like this, http://animevost.org/692%D1%85200.swf

||animevost.org/692%D1%85200.swf works

@Sayueri

Blocked just fine for me. Tested in Firefox, Chrome and Opera.

http://imgwiz.com/images/2015/02/03/5brPh.jpg

@gorhill

||http://animevost.org/692х200.swf is not a valid filter.

|http://animevost.org/692х200.swf is valid.

Writing Adblock Plus filters:

two pipe symbols in front of the filter which makes sure the filter matches at the beginning of the domain name

http is not a domain name.

@gorhill gorhill closed this
@my-password-is-password

@gorhill, |http://animevost.org/692х200.swf works for you?

@gorhill

@my-password-is-password yes. I tried it with |http://animevost.org/favicon.ico, because I don't know where on the site is OP's URL.

@my-password-is-password

Its on the main page http://animevost.org/. Its where @Sayueri screenshot points to

@gorhill

I don't see it in the log.

@my-password-is-password

you have click 2 play?

@gorhill

Works: |http://animevost.org/692%D1%85200.swf

Doesn't work, because Unicode character: |http://animevost.org/692х200.swf

There should be no Unicode character in a filter itself, as it's not allowed anyway in a URL, it should always be percent-encoded. This is supported by the fact that Firefox reports a percent-encoded URL in the log, and in it's own list:

a

@pvlb

Work in ABP FF ||animevost.org/692х200.swf must work in µBlock. Why perversion punycode/percent-encoded in the filters? Corrections will not be? Pipette does not create a filter, and starts advertising. Open the code view (Chrome/FF) and select the file to filter = fail... http://goo.gl/DnnY9R
In FF 'network.standard-url.escape-utf8 → false' use it in µBlock?

p.s. NoScript avtoblock: OBJECT,shockwave-flash@http://animevost.org/692х200.swf

@my-password-is-password

It doesn't work in ABP FF.
You can see the red error message, The pattern you entered no longer matches the address to be blocked/whitelisted and will have no effect on it., when I replace %D1%85 with x. Refreshed the page and the .swf was still there.

Nevermind, forgot to do network.standard-url.escape-utf8 = false like you said. It does work after you set it to false.

@gorhill gorhill reopened this
@gorhill

So there are two issues.

Pipette does not create a filter

The element picker currently doesn't extract URL from object element. I now fixed this locally.

The other issue is dup of #498.

@pvlb

It work in ABP for Firefox ok. http://goo.gl/TP6xKd + network.standard-url.escape-utf8 → false.
yes, dup of #498. thanks for the fix! ;)
FF: OK, Chromium: Issue 68718 and other

@gorhill gorhill added a commit that referenced this issue
@gorhill gorhill this fixes part of #671 a9e9ea4
@gorhill

Second part is dup of #498, so closing as such since 1st-part is fixed.

@gorhill gorhill closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.