Skip to content

Loading…

Cosmetic filtering should be disabled if page is under dynamic filtering `allow` rule #689

Closed
gorhill opened this Issue · 3 comments

2 participants

@gorhill

No description provided.

@Snapy

@gorhill I totally agree. It would fix completely #497 (and the discussion following my comment).

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #689 d0f81f5
@gorhill gorhill closed this in d0f81f5
@gorhill

So from now on, if a web page itself is under a dynamic filtering allow rule -- directly or indirectly, this will disengage cosmetic filtering as well on that site:

@gorhill

@Snapy note that this doesn't work as you expected it to work in #489: this will disengage cosmetic filtering for the current page, but you can't disengage cosmetic filtering for #.embed-twitter specifically: #.embed-twitter is a generic cosmetic filter, there is no way for ublock to know that #.embed-twitter is associated with twitter.com.

It has to be an all or nothing solution, but at least a user now can choose that all-or-nothing solution to apply only to specific web sites. The only doubt I have left regarding the current solution is whether to use the site's own cell (as it is now), or whether to introduce another row dedicated to control cosmetic filtering. To keep adding rows is not ideal however, so for now I settled to evaluate a site's own cell to determine whether cosmetic filtering should be turned off.

This was referenced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.