Skip to content

Loading…

[Fanboy's Social] uBlock twitter share button issue #724

Closed
jtblin opened this Issue · 4 comments

2 participants

@jtblin

I use and love uBlock, well done guys!

That said I have a few issues with the way uBlock blocks the twitter share button. Not only it hides the button but in case the button is in a list, all the items of the list! I have a few other items in the list like Github badges and they all get hidden.

image

I personally think the twitter share button is fine and I think it's a bit annoying that people using uBlock will not see it, why blocking it? There's not many ways to do a bit of free self promotion for OSS projects ;)

Moreover, I am not able to unblock it by whitelisting it. If I had twitter.com or platform.twitter.com, it is still blocked. Looking at the uBlock logs, the highlighted part seems to indicate that tweet_button is what's blocked but that doesn't seem to be a valid entry in the whitelist.

TL;DR;
1. Do we really need to block social sites widgets by default? That seems to come from the "Fanboy’s Social Blocking List‎ (adblockplus.org)". Could that not be not enabled by default?
1. Can we avoid hiding the entire list in case one of the items need to be disabled?
1. How can the twitter button be whitelisted or is the only way to disable the entire "Fanboy's Social Blocking List"? (although that would work only for me)

@ghost

@jtblin The whole point of using a Social Blocking List is because those who enable the list don't want to load buttons from social networks (including Twitter) around the web.

I believe Fanboy’s Social Blocking List‎ is no longer enabled by default. I uninstalled uBlock and then re-installed it from Chrome and it wasn't enabled by default. Haven't tried with the Firefox version yet.

@gorhill

Do we really need to block social sites widgets by default?

"Fanboy’s Social" is not selected by default since version 0.8.2.8.

Can we avoid hiding the entire list in case one of the items need to be disabled?

No. Cosmetic filters are simply CSS selector, they are applied as is.

How can the twitter button be whitelisted?

You need an exception cosmetic filter. It depends what filter you are trying to counter, and on which site. I can't answer without a specific case.

@gorhill gorhill closed this
@jtblin

Hey, thanks for the info. New version does not have the list by default indeed, but I had to uninstall and reinstall it to get rid of it, just updating keep it ticked.

On a different note, I had to disable uBlock today as it was preventing me from booking a flight on expedia.com.au (was preventing a loader lightbox to show which was really inconvenient. Feel like uBlock might be a bit too aggressive in blocking genuine stuff.

@gorhill

@jtblin uBlock uses third-party filter lists, if you think they block too much, report to the list maintainers. You can confirm the problem is the filter lists by trying ABP with exactly the same filter lists (EasyList + EasyPrivacy). If you get the same issue, the problem is in the lists.

@gorhill gorhill changed the title from uBlock twitter share button issue to [Fanboy's Social] uBlock twitter share button issue
@AlexVallat AlexVallat pushed a commit to AlexVallat/uBlock that referenced this issue
@gorhill gorhill re. #724: configurable xhr timeout de2d993
@ahmadassaf ahmadassaf added a commit to ahmadassaf/uBlock that referenced this issue
@ahmadassaf ahmadassaf Merge branch 'master' of https://github.com/gorhill/uBlock
* 'master' of https://github.com/gorhill/uBlock: (66 commits)
  Update README.md
  Exception script tag filter makes no sense: reject such filters
  oops, fix to #756 needs this
  translation work from https://crowdin.com/project/ublock
  comment grammar
  this fixes #756
  this fixes #762
  this fixes #762
  this addresses #759 -- until fix is in EasyPrivacy
  translation work from https://crowdin.com/project/ublock
  code review of new script tag filtering code
  translation work from https://crowdin.com/project/ublock
  new cosmetic filter to foil specific inline script tags
  this addresses #275: test case send through email
  this fixes #640
  reverting #739: this broke normal install
  translation work from https://crowdin.com/project/ublock
  interim version for dev build
  re. #724: configurable xhr timeout
  attempt at fixing #362
  ...
06ce64f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.