Skip to content

Loading…

Dynamic Filtering (Default Deny) - Images not able to unblock using Image cell #739

Closed
harshanvn opened this Issue · 6 comments

2 participants

@harshanvn

I have set up default deny with 0.8.7.0 in Firefox.

 * * 3p block
 * * 3p-frame block

At this (https://github.com/gorhill/uBlock) home page, i see all the images are blocked by default, as expected. However adding a noop rule to local image cell, i see images are still blocked.


github.com * image noop

Looking at the above rule, it created behind the scenes, looks like it is working as expected. However from UI perspective, i am assuming when one clicks noop for image (which is party free), it should unblock the images.

Not sure if my assumption is correct. If this is not an issue and working as expected, you can close the issue as invalid :)

@gorhill gorhill closed this
@gorhill

Re-reading...

@gorhill gorhill reopened this
@gorhill

Ok... Remember?

See: Dynamic filtering: precedence.

If you want higher granularity, there is uMatrix (I do not intend to turn uBlock into uMatrix).

@gorhill gorhill closed this
@harshanvn

Ok... Remember?

Yes, this is what allowed me to raise the issue. I thought noop rule will be in effect for image cell, since it was party free. I wasn't aware of the precedence logic before..

However, after going through the precedence page in the wiki now. It tells, party aware has higher precedence over generic cells. like the example you have given -
3rd-party override images

I am all set now. Once uMatrix comes to Firefox, i will use it instead of dynamic filtering.

@gorhill

The noop rule is to turn a cell back to the equivalent of "no dynamic rule set for this cell".

When the image cell has no rule, 3rd-party images are blocked if 3p is block.

Setting the image cell with a specific noop is to force it to not have any rule, but the precedence logic of rule processing stays the same, or else it is as if you are asking images without rule to not be blocked when 3p is block, which of course is not something we want.

@harshanvn

but the precedence logic of rule processing stays the same, or else it is as if you are asking images without rule to not be blocked when 3p is block, which of course is not something we want.

Yes, Definitely not some thing we want. When taking precedence into the picture, i see what i was asking for, which is not reasonable.

However, i think, i will continue to use 3p script & 3p frames blocking vs 3p cell blocking. I am yet to assess which is better.

@gorhill

Not wanting to block all images when 3p is in block mode defeats the purpose of default-deny. What's the point of blocking all 3rd parties if each one of these 3rd parties could actually just embed a 1-pixel image in the web page so that a network request reaches all of them. In uBlock, allowing all images is a contradiction in default-deny mode. Might as well just disengage default-deny.

It's allowed in uMatrix because you do whatever you want in uMatrix.

@AlexVallat AlexVallat pushed a commit to AlexVallat/uBlock that referenced this issue
@gorhill gorhill reverting #739: this broke normal install f681bac
@ahmadassaf ahmadassaf added a commit to ahmadassaf/uBlock that referenced this issue
@ahmadassaf ahmadassaf Merge branch 'master' of https://github.com/gorhill/uBlock
* 'master' of https://github.com/gorhill/uBlock: (66 commits)
  Update README.md
  Exception script tag filter makes no sense: reject such filters
  oops, fix to #756 needs this
  translation work from https://crowdin.com/project/ublock
  comment grammar
  this fixes #756
  this fixes #762
  this fixes #762
  this addresses #759 -- until fix is in EasyPrivacy
  translation work from https://crowdin.com/project/ublock
  code review of new script tag filtering code
  translation work from https://crowdin.com/project/ublock
  new cosmetic filter to foil specific inline script tags
  this addresses #275: test case send through email
  this fixes #640
  reverting #739: this broke normal install
  translation work from https://crowdin.com/project/ublock
  interim version for dev build
  re. #724: configurable xhr timeout
  attempt at fixing #362
  ...
06ce64f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.