Skip to content

Loading…

[Safari] YouTube ads not being blocked and cannot be skipped #861

Closed
willrun4fun opened this Issue · 8 comments

4 participants

@willrun4fun

YouTube ads are making it through on my Safari install of the last two versions.

The skip button for the ads does not show up either so you are stuck watching the whole thing.

@gorhill gorhill changed the title from YouTube ads not being blocked and cannot be skipped to [Safari] YouTube ads not being blocked and cannot be skipped
@gorhill

Are you using the HTML5 player for Youtube?

@willrun4fun
@chrisaljoudi

@willrun4fun any other extensions installed?

Also, are you able to reproduce this consistently?

@lewisje

I have a wild guess that it could be something that YouTube changed; as ABP developer Sebastian Noack said regarding a separate issue: https://adblockplus.org/forum/viewtopic.php?p=112510#p112510

We inject code into the page, messing with YouTube's JavaScript code, disabling their ads. An approach that isn't trivial and requires quite some afford to be maintained. Therefore we can't do that for every website. Also that approach only works because YouTube configures its video ads with global JavaScript objects, something most other websites don't do.

(emphasis mine)

Maybe YouTube stopped using objects in global scope to configure its video ads, possibly around the time it made HTML5 video the default for most browsers.

@chrisaljoudi

@willrun4fun @lewisje @gorhill fixed in 29fa6cb, which introduces blocking of pragmatic requests made by creating Image()s and better coverage of XMLHttpRequest blocking.

This is a major improvement to Safari's blocking!

@gorhill gorhill removed the need feedback label
@gorhill

@chrisaljoudi I will let you create a 0.8.8.4 release if you want one.

@chrisaljoudi

@gorhill yep.

@chrisaljoudi

@lewisje perhaps, but unlike ABP, µBlock doesn't rely on those global variables to block YouTube ads. µBlock does it by blocking the requests the HTML5 player would use to get the ads.

That's much more general purpose, and it also means µBlock will block any ads it identifiers for any HTML5 player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.