Skip to content

Loading…

Suggestion: warn users that adding multiple lists increases memory usage #894

Closed
Noexpert opened this Issue · 3 comments

2 participants

@Noexpert

If this is already implemented please close.
The temptation is to add all filters but clearly this increases memory usage.

To avoid complaints similar to: "ublock hogs memory!", could we add a simple warning either displayed by default, or only triggered if more than X filters are selected?

@gorhill

To avoid complaints similar to: "ublock hogs memory!"

I never heard such complaints. If there is such complaints, it's baseless, and I am not going to design uBlock according to nonsense.

I added 30 MB hpHosts' hosts.txt the other day:

928,721 filters = 228.87 MB for "Explicit allocations"

ABP with EasyList, EasyPrivacy, Malware domains, Peter Lowe's (uBlock's default lists):

~91,000 filters = 215.86 MB for "Explicit allocations"

@gorhill gorhill closed this
@Noexpert

I wasn't suggesting it uses more memory.

What I'm saying is that by designing an addon which is memory efficient, users will be tempted to select all filters, precisely because it's memory efficient.

Inevitably there will be users that miss the point thinking it uses more memory because they're doing this:

10,000 ublock filters = 10 ABP fliters
251MB > 250MB

@gorhill

It has never been an issue, I fail to see why I should worry it becomes one. The mere fact of warning about memory sort of create a issue about memory, where there is none. Whoever makes such a complaint, I will be happy to officially set the record straight with real numbers.

@dungsaga dungsaga pushed a commit that referenced this issue
@gorhill gorhill this fixes #894 18a95a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.