[Firefox] Image fails to load on github, when page is reloaded after whitelisting image cell..

[harshanvn]

As the title says,
Step 1: configure uBlock as below -

And load the url

As expected, image will not load, since, Images are blocked through dynamic filtering.

step 2:Now whitelist image cell and reload using uBlock Refresh as shown below -

Now image will fail to reload and github says "Sorry, something went wrong. Reload?". If i do a refresh through browser next, it reloads properly.

Below are the logs -

• when image failed to load at step 2
  

• Loaded properly when doing an refresh through browser icon
  

Filter Selected: Ads (1,4), Privacy (All), Malware Domains (1, 4), Social (1, 2), Mulitpurpose (All)
Firefox v36, W7 OS

[Deathamns]

If you know how to build it, try with the current master branch.

[harshanvn]

Unfortunately, i do not know how to do it.
And also, am not in front of personal PC :)

[harshanvn]

dev build : 0.8.9.3-dev.0 fixes the issue. Closing it.
Thanks @Deathamns for the quick fix!

[harshanvn]

@gorhill i do not see this issue linked to release page. shouldn't we do that, for consistency?

[gorhill]

I don't see any code change attached to this issue.

[harshanvn]

this was the commit fixed the issue. And @Deathamns can confirm it.

[gorhill]

Was the bug in a dev build only or was it ever in an official release?

[harshanvn]

this bug existed in 0.8.9.2 and fixed with 0.8.9.3

[gorhill]

The only change in 0.8.9.2 was Safari code, so this can't possibly have been introduced in 0.8.9.2.

Here is the thing: if a bug surfaced in a dev build, and it is fix in a dev build, i.e. if a bug has never been part of an official release, it should not be documented in a release, as this would lead users to believe the bug affected them in a previous release.

So was this ever in an official release?

Edit: I will list them, but in a separate section, which will make clear this affected only users of dev builds.

[harshanvn]

The only change in 0.8.9.2 was Safari code

What i meant was, i encountered/observed the issue in 0.8.9.2 build. It may have been existed before.

Anyways, I see that the issue is still present with v0.9.0.1-dev1. But with a different url, original url works fine!

Steps to reproduce the issue remains the same.

Test URL: gocemitevski@c8bc75d

[Deathamns]

I don't know why Firefox is being clumsy about this, but I think this is a browser bug. It happens also when I restarted the browser without using dynamic filtering.
It seems that bypassing the cache on reload will help.

[harshanvn]

Thanks @Deathamns for the fix gorhill/uBlock@48503f7
Bypassing Cache helps the situation here.
I think we are good now. It should cause no more issues, as always do force-refresh.

@gorhill shouldn't we do force refresh every where, to be in cosistent with firefox implementation. Also, i think it will be ideal to have force refresh, when we unblock/block the requests thru dynamic UI pane.

[gorhill]

shouldn't we do force refresh every where

I don't understand what you mean.

[harshanvn]

force-refresh

meaning Ctrl+F5

[gorhill]

But that's what the refresh button is for. I'm lost.

[harshanvn]

Is it. Then, for some reason in FF it is not doing Ctrl+F5. To fix it, @Deathamns , had to pass the bypass_cache flag to reload method.
I think we are all set then.
We can close the issue.

[gorhill]

bypass_cache flag to reload method

Ok you mean to bypass cache for all platforms (Chromium, Safari)?

[harshanvn]

Yes..
But you already said, Refresh button on popup UI already does that (i.e., ctrl + f5). Or am i missing something here..

[gorhill]

am i missing something here

I am completely lost.

Let's stick to what matters: is the issue originally reported fixed or not? If yes, close please, if not, tell me specifically what does not work.

[harshanvn]

Yes, Reported Issue is fixed.
Will close the issue.