[Firefox] Missing top margin on blocked items counter with Developer Edition theme.

[kasper93]

Hi,

A picture is worth a thousand words:

It doesn't look particularly good on Firefox Developer Edition theme and since it is official one I think the issue should be addressed somehow.

Best Regards,
Kacper

[gorhill]

The badge is sized/positioned by Firefox. @Deathamns could confirm but my guess is that if this bother you, file an issue with Firefox.

[5t3f4n]

If badges are handled by Firefox itself, how come the Disconnect badge (for example) is positioned and styled differently?

µBlock: grey square, upper-right corner.
Disconnect: green rectangle, bottom-right corner.
The font used for the number is also different.

I apologize if this is too off topic.

[gorhill]

how come the Disconnect badge (for example) is positioned and styled differently?

I don't know. Just looking at the code we have currently, I can see that for Firefox 36+, the badge is not being styled at all, aside its background color. This means it's using Firefox default.

[chrisaljoudi]

@5t3f4n

missing top margin

That's not quite what's going on. If you look at the placement of the badge relative to the icon itself, it's identical in both cases:

What is different is the height of the toolbar:

So, the badge positioning is the same; the toolbar merely didn't have as much padding which was why the badge doesn't have the same amount of "space" above it.

The badge is currently not being positioned manually; it's left up to Firefox in Firefox 36+.

[kasper93]

I thought badge is positioned manually. I understand that toolbar have different height, but my impression was that badge could be moved lower to give at least few pixel clearance. Since it is not related to uBlock directly I'm closing this issue. Thanks everyone for comments on this topic.

PS. I noticed also one more thing, "update" badge is on top title bar, while uBlock's badge is truncated. We are talking one pixel here, but still it is surprising that the difference exist in the first place.