Skip to content

Loading…

abp:subscribe, new automated import of ABP filters leads to undefined description #982

Closed
ghost opened this Issue · 3 comments

1 participant

@ghost

This is on the daily build, with the experimental automatic ABP filter list import feature.

To recreate go to:

https://youtube.adblockplus.me/en/

(or the other list pages)

Importing a filter list will lead to the Filter title description as "undefined." Manually importing a new filter into the text field results in "undefined" as well.

Additionally, commented out filter lists appear to drop down into the next line enabling them.

@ghost ghost changed the title from [Firefox] abp:subscribe, automated import of ABP filters leads to undefined description to [Firefox] abp:subscribe, new automated import of ABP filters leads to undefined description
@gorhill

I can reproduce by just pasting the URL in the custom filter lists area, so not related to abp:subscribe.

@gorhill

This happens when the remote server doesn't return the resource.

Fixed locally.

@gorhill gorhill added a commit that closed this issue
@gorhill gorhill this fixes #982, #978, #965 39ad158
@gorhill gorhill closed this in 39ad158
@gorhill gorhill changed the title from [Firefox] abp:subscribe, new automated import of ABP filters leads to undefined description to abp:subscribe, new automated import of ABP filters leads to undefined description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.