Skip to content

Loading…

The Element Hider doesn't work on some websites #99

Closed
JBey4you opened this Issue · 3 comments

2 participants

@JBey4you

I just find out that the Element Hider feature -- which is great by the way -- doesn't work on some websites. For an example, 9to5Mac.com: the eye to activate the feature doesn't appear at all.

capture decran 2014-07-25 a 20 12 02

On MacWorld.com, it's an another thing. I can activate the Element Hider feature, although it does nothing when I choose a element (in that case the autoplay video on the right).

capture decran 2014-07-25 a 20 13 21
I'm clicking, but it does nothing

Am I alone?

PS: Since I'm talking about MacWorld, the header doesn't work with uBlock. If I click on the logo or a section (News, Reviews, How-to, etc), it does absolutely nothing. It works with uBlock disabled.

@gorhill

Ok I fixed for 9to5Mac.com. I forgot hostname labels can start with a digit.

The other problem is.... The click doesn't work because they use an event listener on the whole document, and they cancels the click event if they can't track your action on the site (something like that). Not the first site I see doing this. The whole site is bent on tracking what you do, and if you happen to actually block the embedded tracker, links won't work etc so that this discourage people from blocking their abuse (right-click is workaround in such case).

Anyways, I suppose I have to put the event listener at the root rather than the overlay.

@gorhill

Ok second part will take more time to fix, if there is any fix: they destroy the click event, so the element picker never receives it, even if I register the event listener on the root of the document. ABP has same problem.

@gorhill gorhill added a commit that referenced this issue
@gorhill gorhill this addresses 1st part of #99 a71b9b4
@gorhill

Looks like it works on MacWorld.com now.

@gorhill gorhill closed this
@ahmadassaf ahmadassaf pushed a commit to ahmadassaf/uBlock that referenced this issue
@gorhill gorhill this fixes #99, #991: ability to popunders 6418e6b
@ahmadassaf ahmadassaf pushed a commit to ahmadassaf/uBlock that referenced this issue
@gorhill gorhill this fixes #99, #991: ability to block popunders c39b892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.