
Loading…
[Firefox] Can something be done to improve popup oppening animation? #996
The code to deal with resizing is already dubious, to work around arbitrary browser behavior, and frankly I think the issue should be opened on Firefox side instead.
My glicthes a little too, but not as bad looking as this image that is playing.
My actually fickers a little when it opens.
I'm using 31.5.0 ESR in Linux.
There are two different things happening here:
- The popup needs to confiigure itself according to whether the dynamic filtering pane is visible or not.
- As a consequence, the frame which contains the popup UI may need to resize accordingly:
- For Chromium-based browsers, uBlock doesn't have to resize itself that frame, the browser takes care of this.
- For Firefox, uBlock has to resize the frame, Firefox is not doing it properly.
Which language is this by the way? The request type strings are way too long. An issue should be filed on Crowdin for that issue.
For part 1, it could be useful to pre-configure the visibility of dynamic filtering pane to the last known state without waiting for an asynchronous answer from the background process, maybe the localStorage object talked about in issue #792 could help with this. Still, given how Firefox container frame work, not sure this would solve the problem, but I feel this may help.
@gorhill commented on 13 mar 2015, 23:37 CET:
Which language is this by the way? The request type strings are way too long. An issue should be filed on Crowdin for that issue.
Polish
Not a laptop, but old PC (Dual-Core E2160@2,4GHz).
But this is just a popup... :(
Nothing change after gorhill/uBlock@aadd95c
Here's how it looks in FF nightly v39 http://i.imgur.com/V246MLE.gif
EDIT: Exactly the same experience, either with 0.9.0.1 and 0.9.1.1
Hardcoding <div id="panes" class="dfEnabled"> helps.
Still not smooth, but no longer flickers and jumps left/right.
Hardcoding
<div id="panes" class="dfEnabled">helps
Then it will become ugly for a majority of users, those who do not use dynamic filtering.
gorhill/uBlock@db15861 still nothing
File an issue with Firefox. Looks like resizable popup UI is just not very well supported.
Looks good most of the time after gorhill/uBlock@3d43ad4
774e30a should help this, too.
Things are now pretty much perfect in my testing (Firefox 36.0.1; OS X), especially when toggling dynamic filtering.
This now affects Safari as well in #1068. I'm also now seeing it in Chrome but it is not consistent as it is in Safari.
Would it be possible for advanced users like myself to have an option to always show it in a specific size without ever resizing it?
@gorhill Wouldn't it be possible to set the panel as invisible, render it, get its size, resize the frame, and then display it? There would be a small latency, but at least it wouldn't flicker this way.

Looks like this is on Fx 37b. On Opera (Chrome?) this 'flickering' is barely visible.