Skip to content

/uBlock

Loading…

Add tooltip for information. #123

Merged
merged 1 commit into from
+1 −1

Labels

None yet

Milestone

No milestone

Assignee

No one assigned

2 participants

@bearbin @gorhill
@bearbin
bearbin commented

It was confusing at first what this did. Hopefully this fixes that.

@gorhill
gorhill commented on a2ba19d

Best to enter an issue for this. The problem with this fix is that it's good for the English locale only. To support all locales the fix is different.

bearbin replied

Oh, I thought it would be fine because the h4 above it has the same unlocalised title attribute.

gorhill replied

Ah that's right, I should fix this one too at the same time.

bearbin replied

So should I close the PR and open an issue so it can be fixed later?

@gorhill gorhill referenced this pull request
Closed

Localize fully popup menu #124

@gorhill
gorhill commented

So should I close the PR and open an issue so it can be fixed later?

Sorry, I went ahead and opened it already.

@gorhill gorhill merged commit 16c8d7f into chrisaljoudi:master
@chrisaljoudi chrisaljoudi pushed a commit that referenced this pull request
@gorhill gorhill this fixes #123 782ea0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 31, 2014
  1. @bearbin

    Add tooltip for information.

    bearbin committed
    4
    a2ba19d
This page is out of date. Refresh to see the latest.
Unified Split
Showing with 1 addition and 1 deletion.
  1. +1 −1 popup.html
View
2 popup.html
@@ -98,7 +98,7 @@ <h4 title="Click to open the dashboard">µBlock<span id="version"></span></h4>
<p id="switch"><span class="fa">&#xf011;</span></p>
<p id="switch-hint" data-i18n="popupPowerSwitchInfo"></p>
<p style="font-size: 16px;" data-i18n="popupBlockedRequestPrompt"></p>
-<p id="stats"><span data-i18n="popupBlockedOnThisPagePrompt"></span>&ensp;<span id="gotoPick" class="fa tool">&#xf070;</span>&ensp;<span id="gotoLog" class="fa tool">&#xf06e;</span></p>
+<p id="stats"><span data-i18n="popupBlockedOnThisPagePrompt"></span>&ensp;<span id="gotoPick" title="Pick element on page" class="fa tool">&#xf070;</span>&ensp;<span id="gotoLog" class="fa tool">&#xf06e;</span></p>
<p id="page-blocked">?</p>
<p id="stats" data-i18n="popupBlockedSinceInstallPrompt"></p>
<p id="total-blocked">?</p>
Something went wrong with that request. Please try again.