Skip to content

Loading…

prefer https #1250

Merged
merged 1 commit into from

4 participants

@b3rnd

No description provided.

@lewisje

While you're at it, it might be better to prefer rawgit.com over raw.githubusercontent.com (to reduce bandwidth on GitHub's servers).

@b3rnd

http://rawgit.com/faq - "Requests to cdn.rawgit.com are routed through MaxCDN's super fast content delivery network, and are cached permanently" - means no updated filter lists, right? not really what we want... ;)

@lewisje

I guess you mean client-side, because I know that it gets updated on RawGit when I update a file on GitHub.

@chrisaljoudi
Owner

@lewisje @b3rnd

RawGit provides two URLs:

rawgit urls

The CDN URL is indeed cached permanently (tested here), but the other one (the non-CDN one) isn't cached permanently and will occasionally issue more requests to GitHub for updates.

Given those circumstances, it'd have to be either rawgit.com or raw.githubusercontent.com (not cdn.rawgit.com).

However, the only advantage to using rawgit.com is the Content-type headers being appropriate (plus a small amount of short-term caching). Other than that, it hits both rawgit.com and raw.githubusercontent.com (which is arguably worse than just hitting the latter).

So it seems like raw.githubusercontent.com is the only reasonable answer for lists hosted exclusively on GitHub.

@jvoisin

Is there something to correct/fix/improve to get this pull-request merged?

@chrisaljoudi chrisaljoudi merged commit a70a500 into chrisaljoudi:master

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 13, 2015
  1. @b3rnd

    prefer https

    b3rnd committed
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 assets/ublock/filter-lists.json
View
4 assets/ublock/filter-lists.json
@@ -213,7 +213,7 @@
"off": true,
"title": "FIN: Wiltteri",
"group": "regions",
- "homeURL": "http://raw.githubusercontent.com/wiltteri/wiltteri.txt/master/wiltteri.txt"
+ "homeURL": "https://raw.githubusercontent.com/wiltteri/wiltteri.txt/master/wiltteri.txt"
},
"someonewhocares.org/hosts/hosts": {
"off": true,
@@ -225,7 +225,7 @@
"off": true,
"title": "Spam404",
"group": "malware",
- "homeURL": "http://spam404bl.com/spam404scamlist.txt"
+ "homeURL": "https://spam404bl.com/spam404scamlist.txt"
},
"stanev.org/abp/adblock_bg.txt": {
"off": true,
Something went wrong with that request. Please try again.