this fixes overlooked code change in 1d3205ea817ccb8a2f03bbaecc9daf19… #1388

gorhill · May 17, 2015

Looks like a bit of code was overlooked following the changes in 1d3205e.

The data in the this.REQDATAKEY property bag is not properly ordered for behind-the-scene requests. httpObserver.asyncOnChannelRedirect (and further httpObserver.observer notifications for same requests) expects the data to be ordered as follow: frameId, parentFrameId, sourceTabId, tabId, type.

chrisaljoudi · May 18, 2015

@gorhill Thanks!

gorhill · May 18, 2015

I should have mentioned this was extremely unlikely -- if at all -- to have caused any problem.

jqsjqs · Oct 30, 2015

@ChangeTip, send a coffee to @gorhill

Hi - thanks for making uBlock. :)

changetip · Oct 30, 2015

Hi @gorhill, @jqsjqs sent you a tip worth a coffee (4,639 bits/$1.50), and I'm here to deliver it ➔ collect your tip.

Learn more about ChangeTip

gorhill this fixes overlooked code change in 1d3205e

7b652bd

chrisaljoudi merged commit 0c7b0cc into chrisaljoudi:master May 18, 2015
1 check passed

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed

@@ @@ -1209,7 +1209,7 @@ var httpObserver = { @@
                  // Carry data for behind-the-scene redirects
                  channel.setProperty(
                      this.REQDATAKEY,
-    -                [lastRequest.type, vAPI.noTabId, null, 0, -1]
+    +                [0, -1, null, vAPI.noTabId, lastRequest.type]
                  );
                  return;
              }

chrisaljoudi/uBlock

this fixes overlooked code change in 1d3205ea817ccb8a2f03bbaecc9daf19… #1388

Labels

Milestone

Assignee

4 participants

1 check passed