Skip to content

/uBlock

Loading…

textarea elements rtl/ltr fixes #176

Merged
merged 12 commits into from
+4 −3

Labels

None yet

Milestone

No milestone

Assignee

No one assigned

4 participants

@Mikey1993 @gorhill @tailHey @Baegus
@Mikey1993
Mikey1993 commented

Fixing textareas resizer side on 3p-filters and the blinker not behaving right when writing in English on some textareas.

Recomitting this after some realizations.
Well, I have just realized that there is a need for dir="auto" property on all textareas ,EXCEPT the one on the 3p-filters, to correct the position of the blinker while writing in English - which I still don't quite sure.
The textarea on 3p-filters only needs text-align: ltr rule so that all the text will start from left to right.

The direction rule only needed for the textarea in 3p-filters to have the resize grabber on the right side (in rtl languages).

@gorhill gorhill merged commit 7e4c734 into chrisaljoudi:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 23, 2014
  1. @tailHey @Mikey1993

    Updated 0.5.x French translation

    tailHey committed with Mikey1993
    5626a64
  2. @gorhill @Mikey1993

    this fixes #166

    gorhill committed with Mikey1993
    07648d4
  3. @gorhill @Mikey1993

    typo

    gorhill committed with Mikey1993
    cbef40a
  4. @gorhill @Mikey1993

    svg of uBlock's icon authored by https://github.com/Baegus (#168)

    gorhill committed with Mikey1993
    a02a2cc
  5. @Baegus @Mikey1993

    Deleted some unused hidden layers

    Baegus committed with Mikey1993
    2115cf6
  6. @gorhill @Mikey1993

    translation work from contributors on Crowdin

    gorhill committed with Mikey1993
    dad09ac
  7. @Mikey1993

    Merge branch 'master' of https://github.com/gorhill/uBlock

    Mikey1993 committed
    8d003b2
  8. @Mikey1993

    Merge branch 'master' of https://github.com/gorhill/uBlock

    Mikey1993 committed
    d501934
  9. @Mikey1993

    Merge branch 'master' of https://github.com/gorhill/uBlock

    Mikey1993 committed
    6bf1661
  10. @Mikey1993

    Merge branch 'master' of https://github.com/gorhill/uBlock

    Mikey1993 committed
    a315126
  11. @Mikey1993

    textarea elements rtl/ltr fixes …

    Mikey1993 committed 
    Fixing textareas resizer side on 3p-filters and English text not being
written as it should on all textareas.
    78772d8
Commits on Aug 24, 2014
  1. @Mikey1993

    some more css fixes to textareas …

    Mikey1993 committed 
    Fixing textareas resizer side on 3p-filters and the blinker not behaving
right when writing in English on some textareas.
    1fa32ec
This page is out of date. Refresh to see the latest.
Unified Split
Showing with 4 additions and 3 deletions.
  1. +1 −1 1p-filters.html
  2. +2 −1 css/3p-filters.css
  3. +1 −1 whitelist.html
View
2 1p-filters.html
@@ -26,7 +26,7 @@
<div>
<p data-i18n="1pFormatHint"></p>
<p><button id="importUserFiltersFromFile" data-i18n="1pImport"></button> &emsp; <button id="exportUserFiltersToFile" data-i18n="1pExport"></button></p>
- <textarea class="userFilters" id="userFilters"></textarea>
+ <textarea class="userFilters" id="userFilters" dir="auto"></textarea>
<p><button id="userFiltersApply" disabled="true" data-i18n="1pApplyChanges"></button></p>
</div>
View
3 css/3p-filters.css
@@ -94,7 +94,8 @@ span.obsolete {
width: 48em;
height: 8em;
white-space: nowrap;
- direction: ltr;
+ direction: __MSG_@@bidi_dir__;
+ text-align: left;
}
body #loadingOverlay {
position: fixed;
View
2 whitelist.html
@@ -29,7 +29,7 @@
<div>
<p data-i18n="whitelistPrompt"></p>
<p><button id="importWhitelistFromFile" data-i18n="whitelistImport"></button> &emsp; <button id="exportWhitelistToFile" data-i18n="whitelistExport"></button></p>
- <textarea id="whitelist"></textarea>
+ <textarea id="whitelist" dir="auto"></textarea>
<p><button id="whitelistApply" type="button" disabled="true" data-i18n="whitelistApply"></button></p>
</div>
Something went wrong with that request. Please try again.