Fix `set` for Firefox & Safari (skip non-own properties in for..in loop) #537

chrisaljoudi · Jan 18, 2015

Should fix #523

chrisaljoudi Fix `set` for Firefox & Safari (don't set non-own properties in for..… …
…in loop)

5aafafd

chrisaljoudi referenced this pull request Jan 18, 2015
Closed
[Safari] Clearing history and website data stops uBlock on restart #523

gorhill merged commit e8fb45d into chrisaljoudi:master Jan 18, 2015
1 check passed

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed

@@ @@ -195,6 +195,9 @@ vAPI.storage = { @@
              var key, values = [], placeholders = [];
              for ( key in details ) {
+    +            if ( !details.hasOwnProperty(key) ) {
+    +                continue;
+    +            }
                  values.push(key);
                  values.push(JSON.stringify(details[key]));
                  placeholders.push('?, ?');

@@ @@ -126,6 +126,9 @@ vAPI.storage = { @@
          set: function(details, callback) {
              for ( var key in details ) {
+    +            if ( !details.hasOwnProperty(key) ) {
+    +                continue;
+    +            }
                  this._storage.setItem(key, JSON.stringify(details[key]));
              }

chrisaljoudi/uBlock

Fix `set` for Firefox & Safari (skip non-own properties in for..in loop) #537

Labels

Milestone

Assignee

2 participants

[Safari] Clearing history and website data stops uBlock on restart #523

1 check passed