Skip to content

Loading…

dynamic-net-filtering.js length typos #605

Merged
merged 1 commit into from

2 participants

@barri

Corrected length typos in dynamic-net-filtering.js in the is3rdParty function.

@barri barri dynamic-net-filtering.js length typos
Corrected length typos in dynamic-net-filtering.js in the is3rdParty function.
206eda7
@gorhill gorhill merged commit 5d4aef0 into chrisaljoudi:master
@gorhill

Crap... Thanks for catching that, that's a pretty serious mistake. This means uBlock was unable to detect 1st-party.

@barri barri deleted the unknown repository branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 26, 2015
  1. @barri

    dynamic-net-filtering.js length typos

    barri committed
    Corrected length typos in dynamic-net-filtering.js in the is3rdParty function.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/js/dynamic-net-filtering.js
View
2 src/js/dynamic-net-filtering.js
@@ -209,7 +209,7 @@ var is3rdParty = function(srcHostname, desHostname) {
return true;
}
// Do not confuse 'example.com' with 'anotherexample.com'
- return desHostname.lenght !== srcDomain.lenght &&
+ return desHostname.length !== srcDomain.length &&
desHostname.charAt(desHostname.length - srcDomain.length - 1) !== '.';
};
Something went wrong with that request. Please try again.