New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (actually almost/kinda a rewrite) #3

Merged
merged 10 commits into from Oct 14, 2016

Conversation

Projects
None yet
2 participants
@cmtonkinson
Contributor

cmtonkinson commented Oct 14, 2016

Save original images before optimizing
Add options: archive_dir, cache_file, image_glob
Flesh out the README

@cmtonkinson

This comment has been minimized.

Contributor

cmtonkinson commented Oct 14, 2016

This is a pretty major change, but the end result isn't totally incompatible with your original work, so if you don't like the changes, I'll just keep my fork separate, but if you like it I'm happy to PR back in and keep it all under one namespace.

@chrisanthropic chrisanthropic merged commit ad8d638 into chrisanthropic:master Oct 14, 2016

@chrisanthropic

This comment has been minimized.

Owner

chrisanthropic commented Oct 14, 2016

This is awesome, I was never happy with the code before and your rewrite looks great.

Thanks!

@cmtonkinson

This comment has been minimized.

Contributor

cmtonkinson commented Oct 14, 2016

You're very welcome - you had a really solid foundation so it was a breeze; all I did was tidy it up a bit.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment