This repository has been archived by the owner on Jan 10, 2021. It is now read-only.
Refactor (actually almost/kinda a rewrite) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor for style/whitespace Parameterize configuration, allowing default overrides in _config.yml Save original images to archive with date/time and digest
|
This is a pretty major change, but the end result isn't totally incompatible with your original work, so if you don't like the changes, I'll just keep my fork separate, but if you like it I'm happy to PR back in and keep it all under one namespace. |
|
This is awesome, I was never happy with the code before and your rewrite looks great. Thanks! |
|
You're very welcome - you had a really solid foundation so it was a breeze; all I did was tidy it up a bit. Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Save original images before optimizing
Add options: archive_dir, cache_file, image_glob
Flesh out the README