Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Build (following #271) #273

Merged
merged 10 commits into from Feb 24, 2019

Conversation

Projects
None yet
3 participants
@chrisbanes
Copy link
Owner

chrisbanes commented Feb 24, 2019

Following on from #271

chrisbanes and others added some commits Nov 5, 2018

Merge pull request #271 from rharter/rh/cloud-build
Google Cloud Build implementation
@googlebot

This comment was marked as resolved.

Copy link
Collaborator

googlebot commented Feb 24, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Feb 24, 2019

@chrisbanes chrisbanes added cla: yes and removed cla: no labels Feb 24, 2019

@googlebot

This comment was marked as resolved.

Copy link
Collaborator

googlebot commented Feb 24, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 24, 2019

Repository owner deleted a comment from googlebot Feb 24, 2019

@chrisbanes chrisbanes added cla: yes and removed cla: no labels Feb 24, 2019

@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Feb 24, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@chrisbanes chrisbanes force-pushed the google-cloud-build branch from ed5032c to 974ed48 Feb 24, 2019

@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Feb 24, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 24, 2019

@chrisbanes chrisbanes added cla: yes and removed cla: no labels Feb 24, 2019

@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Feb 24, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@chrisbanes chrisbanes merged commit 69c49e8 into master Feb 24, 2019

4 checks passed

ci/circleci: build_debug Your tests passed on CircleCI!
Details
ci/circleci: build_release Your tests passed on CircleCI!
Details
ci/circleci: check Your tests passed on CircleCI!
Details
cla/google CLAs have been manually verified by Googler who has set the 'cla: yes' label

@chrisbanes chrisbanes deleted the google-cloud-build branch Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.